[Webkit-unassigned] [Bug 69220] Fix FrameView::scrollElementToRect to take already scrolled amount into consideration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 12:06:47 PDT 2011


--- Comment #7 from Alexey Proskuryakov <ap at webkit.org>  2011-10-03 12:06:44 PST ---
> The patch makes sure it is not relative to the current scroll amount (please see the updated layout test).

OK. Bug title could be improved - it says "take already scrolled amount into consideration", while you are making it so that the function actually ignores.

I agree with Fady that it's the use of scrollBy that seems wrong here.

> For context, please see https://bugs.webkit.org/show_bug.cgi?id=68198

There is no rationale in that bug. It's about moving some Chromium code into WebCore, but I don't see an explanation of why this code is needed in the first place. It's a pity that only Chromium developers looked at that bug.

A function that has the goal to make something visible should have "reveal" in its name to match the rest of WebCore. As opposed to scrolling to a point, a "reveal" function is allowed to make some platform specific decisions as to which side of the visible area the element will appear at, and how far from the side.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list