[Webkit-unassigned] [Bug 69266] New: REGRESSION (r84225): Virtual function called from Node::parentNode()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 09:37:10 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69266

           Summary: REGRESSION (r84225): Virtual function called from
                    Node::parentNode()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: koivisto at iki.fi
                CC: dglazkov at chromium.org, morrita at google.com


http://trac.webkit.org/changeset/84225 from bug 52788 added a virtual function call (isSVGShadowRoot()) to Node::parentNode():

 inline ContainerNode* Node::parentNode() const
 {
-    return getFlag(IsShadowRootFlag) ? 0 : parent();
+    return getFlag(IsShadowRootFlag) || isSVGShadowRoot() ? 0 : parent();
 }

This regresses everything that depends on walking up the tree, most crucially CSS selector matching.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list