[Webkit-unassigned] [Bug 69255] [GTK] Implement default error pages in WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69255





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-10-03 09:36:31 PST ---
(From update of attachment 109475)
View in context: https://bugs.webkit.org/attachment.cgi?id=109475&action=review

Looks fine to me, but I'm not sure if it's the right thing to do to "hide" the loading of the error page from the API.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:72
> +    WebKitWebLoaderClient* client = WEBKIT_WEB_LOADER_CLIENT(clientInfo);
> +    if (client->priv->loadingErrorPage)
> +        return;
> +
>      gboolean returnValue;
> -    g_signal_emit(WEBKIT_WEB_LOADER_CLIENT(clientInfo), signals[PROVISIONAL_LOAD_STARTED], 0, &returnValue);
> +    g_signal_emit(client, signals[PROVISIONAL_LOAD_STARTED], 0, &returnValue);

Are you sure it's good to hide inner workings of the error page load from the API?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:84
> +    WebKitWebLoaderClient* client = WEBKIT_WEB_LOADER_CLIENT(clientInfo);
> +    if (client->priv->loadingErrorPage)
> +        return;
> +
>      gboolean returnValue;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.