[Webkit-unassigned] [Bug 68861] Support for multiple <link rel="icon"> favicon elements - LayoutTests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68861


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109068|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #13 from Darin Adler <darin at apple.com>  2011-10-03 07:42:01 PST ---
(From update of attachment 109068)
View in context: https://bugs.webkit.org/attachment.cgi?id=109068&action=review

> Source/WebCore/testing/Internals.cpp:393
> +    String result;

Yes, as Adam says, this should be a StringBuilder. String's += operation is extremely inefficient and even for test code would be better to not use it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.