[Webkit-unassigned] [Bug 69249] [GTK][WEBKIT2] Add webkit_web_view_load_html_string and webkit_web_view_load_plain_text APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69249





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-03 05:56:27 PST ---
(From update of attachment 109473)
View in context: https://bugs.webkit.org/attachment.cgi?id=109473&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:277
> +void webkit_web_view_load_html_string(WebKitWebView* webView, const gchar* content, const gchar* baseUri)
> +{
> +    g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
> +

baseUri can be NULL, but you should check content is not NULL. I didn't notice it was missing in previous patch, sorry.

> Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:232
> +typedef struct {
> +    WebKitWebView *webView;
> +    GMainLoop *loop;
> +    gboolean hasBeenFinished;
> +} HtmlStringLoadingFixture;

You can use the same Fixture for new tests.

> Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:234
> +static void htmlStringLoadingNotifyTitleCb(WebKitWebView* webView, GParamSpec* pSpec, HtmlStringLoadingFixture* fixture)

Tests are C, not C++, so it should be WebKitWebView *webView, GParamSpec *pSpec, HtmlStringLoadingFixture *fixture)

> Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:238
> +    const gchar* title = webkit_web_view_get_title(webView);

* is missplaced here too.

> Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:278
> +    g_signal_connect(client, "load-failed", G_CALLBACK(htmlStringLoadStatusLoadFailed), fixture);

You should check provisional-load-failed too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.