[Webkit-unassigned] [Bug 69249] [GTK][WEBKIT2] Add webkit_web_view_load_html_string and webkit_web_view_load_plain_text APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69249





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-03 04:44:03 PST ---
(From update of attachment 109466)
View in context: https://bugs.webkit.org/attachment.cgi?id=109466&action=review

> Source/WebKit2/GNUmakefile.am:1087
> -	Programs/unittests/webkit2/testloading
> +	Programs/unittests/webkit2/testloading \
> +	Programs/unittests/webkit2/testhtmlstringloading \
> +	Programs/unittests/webkit2/testplaintextloading

I don't think we need new tests, just add two new test cases to the existing testloading.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:277
> +    g_return_if_fail(baseUri);

The documentation says NULL is allowed for baseUri, about:blank is used.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:280
> +    WKPageLoadHTMLString(toAPI(page), WKStringCreateWithUTF8CString(content), WKURLCreateWithUTF8CString(baseUri));

You are leaking the WKURL and WKString, see bug https://bugs.webkit.org/show_bug.cgi?id=69247

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:296
> +    WKPageLoadPlainTextString(toAPI(page), WKStringCreateWithUTF8CString(plainText));

And here the WKString

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.