[Webkit-unassigned] [Bug 65760] CSSSelector::selectorText should use StringBuilder instead of +=

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 2 22:25:04 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65760


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105583|review?                     |review-
               Flag|                            |




--- Comment #2 from MORITA Hajime <morrita at google.com>  2011-10-02 22:25:04 PST ---
(From update of attachment 105583)
View in context: https://bugs.webkit.org/attachment.cgi?id=105583&action=review

> Source/WebCore/css/CSSSelector.cpp:629
>      if (CSSSelector* tagHistory = cs->tagHistory()) {

How about just to return and eliminate temporal "str" ?
Also, you can do early return by checking tagHistory != NULL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list