[Webkit-unassigned] [Bug 69220] Fix FrameView::scrollElementToRect to take already scrolled amount into consideration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 1 23:19:33 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69220





--- Comment #3 from sadrul at chromium.org  2011-10-01 23:19:33 PST ---
(In reply to comment #2)
> What actual bug does this fix?
> 
> From the function name, it sounds like it should not be relative to current scroll amount, so this patch seems wrong.

For context, please see https://bugs.webkit.org/show_bug.cgi?id=68198

The function is expected to move the specified element into the specified rectangular region (where the specified rectangular region represents the visible region in the client), and scroll the frame if needed. The function computes the amount needed to scroll from the top of the page, but does not take into consideration if the page is already scrolled some amount. So it ends up overscrolling when called in an already scrolled page. This patch fixes that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list