[Webkit-unassigned] [Bug 68753] [WinCairo] BitmapImage::drawFrameMatchingSourceSize causes access violation if BitmapImage::frameAtIndex() returns NULL

Sat Oct 1 22:14:00 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68753

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Brent Fulgham <bfulgham at webkit.org>  2011-10-01 22:14:00 PST ---
Nice catch!

(In reply to comment #2)
> (From update of attachment 108581 
> I think this would be a little clearer using an early continue:
> 
> cairo_surface_t* image = frameAtIndex(i);
> if (!image)
>     continue;

I agree. Please make this change, and let me know about the test case.

Thanks!

-Brent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.