[Webkit-unassigned] [Bug 72046] New: [chromium] WebPluginContainerImpl::executeScriptURL() doesn't properly signal success/failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72046

           Summary: [chromium] WebPluginContainerImpl::executeScriptURL()
                    doesn't properly signal success/failure
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: viettrungluu at chromium.org


WebPluginContainerImpl::executeScriptURL() is supposed to return a null string on failure. Unfortunately, it does:

    ScriptValue result = frame->script()->executeScript(script, popupsAllowed);

    // Failure is reported as a null string.
    String resultStr;
    result.getString(resultStr);
    return resultStr;

|result.getString(resultStr)| just leaves |resultStr| as-is if |result| isn't a string.

I *think* what we should do is return a null string in the case that |result.hasNoValue()| is true, otherwise return an empty string if |result.getString(resultStr)| returns false or |resultStr| when it returns true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.