[Webkit-unassigned] [Bug 72939] Asynchronous SpellChecker should consider multiple requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72939


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117330|review?                     |review-
               Flag|                            |




--- Comment #4 from MORITA Hajime <morrita at google.com>  2011-11-30 22:41:43 PST ---
(From update of attachment 117330)
View in context: https://bugs.webkit.org/attachment.cgi?id=117330&action=review

Let's have another round. I realized that the problem is more tricky than what I thought....

> Source/WebCore/editing/SpellChecker.cpp:102
> +    if (!m_queuedRequest.get())

Is this possible to true? If not, please add ASSERT().
It's ok to return here for safety, though.

> Source/WebCore/editing/SpellChecker.cpp:105
> +    m_processingRequest = m_queuedRequest.release();

I think it is possible to overwrite existing m_processingRequest here and it's node desirable.

> Source/WebCore/editing/SpellChecker.cpp:112
> +    if (!m_queuedRequest.get())

NIt: you don't need get() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.