[Webkit-unassigned] [Bug 73280] Upstream credential storage files of BlackBerry porting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73280


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117315|review?                     |review-
               Flag|                            |




--- Comment #5 from Antonio Gomes <tonikitoo at webkit.org>  2011-11-30 20:44:07 PST ---
(From update of attachment 117315)
View in context: https://bugs.webkit.org/attachment.cgi?id=117315&action=review

it looks good.

r- because we need another round to fix the nits.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:53
> +bool CredentialBackingStore::open(const String& dbPath)

UNUSED_PARAM(dbPath) missing.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:68
> +bool CredentialBackingStore::addLogin(const KURL& url, const ProtectionSpace& protectionSpace, const Credential& credential)
> +{
> +    notImplemented();
> +    return false;
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:74
> +bool CredentialBackingStore::updateLogin(const KURL& url, const ProtectionSpace& protectionSpace, const Credential& credential)
> +{
> +    notImplemented();
> +    return false;
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:86
> +Credential CredentialBackingStore::getLogin(const ProtectionSpace& protectionSpace)
> +{
> +    notImplemented();
> +    return Credential();
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:92
> +{
> +    notImplemented();
> +    return false;
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.h:55
> +    SQLiteStatement *m_addStatement;
> +    SQLiteStatement *m_updateStatement;
> +    SQLiteStatement *m_hasStatement;
> +    SQLiteStatement *m_getStatement;
> +    SQLiteStatement *m_removeStatement;

* position on the left

> Source/WebCore/platform/network/blackberry/CredentialStorageBlackBerry.cpp:35
> +#else
> +    return Credential();
> +#endif

UNUSED_PARAM needed here too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.