[Webkit-unassigned] [Bug 73513] [Blackberry] Upstream BlackBerry porting of plugin framework -- part 2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73513


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117318|review?                     |review+
               Flag|                            |




--- Comment #4 from Antonio Gomes <tonikitoo at webkit.org>  2011-11-30 20:39:27 PST ---
(From update of attachment 117318)
View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review

> Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:183
> +    FrameView* frameView = static_cast<FrameView*>(m_view->parent());
> +
> +    if (preventIdle == m_idlePrevented)
> +        return;

we could move the early return before the ' frameview = xxx' lines.

> Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:325
> +    for (int i = 0; (i < PLUGIN_BUFFERS) && success; i++) {

unneeded ()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.