[Webkit-unassigned] [Bug 73185] [blackberry] Upstream BlackBerry porting of plugin framework

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73185


Charles Wei <charles.wei at torchmobile.com.cn> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #23 from Charles Wei <charles.wei at torchmobile.com.cn>  2011-11-30 19:51:11 PST ---

> 
> there are some nits, but it looks good r+.
> 
> Please fix them before landing :)
> 
> > Source/WebCore/plugins/blackberry/NPCallbacksBlackBerry.cpp:77
> > +    PluginView* view = static_cast<PluginView*>(instance->ndata);
> > +    PluginViewPrivate* viewPrivate = view->getPrivate();
> 
> maybe we could make it a helper static local function: toPluginView (or a better name)?
> 

----  This view->getPrivate() is defined in the base class PluginView. in the upper directory, which has not been landed. So we will keep this as is for now until the PluginView.h is also upstreamed. 

> > Source/WebCore/plugins/blackberry/NPCallbacksBlackBerry.cpp:156
> > +NPSurface lockReadFrontBuffer(NPP instance)
> > +{
> > +PluginView* view = static_cast<PluginView*>(instance->ndata);
> > +PluginViewPrivate* viewPrivate = view->getPrivate();
> > +return viewPrivate->lockReadFrontBuffer();
> > +}
> > 
> ps: identation issue here!

---- This will be fixed in the new patch.

Thanks Antonio, for the review.  I am moving the thread to a new bug,  73513, for better tracking since there are too many discussions here , and as suggested, I should not re-open this bug since it's already automatically closed by the system.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.