[Webkit-unassigned] [Bug 73280] Upstream credential storage files of BlackBerry porting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73280





--- Comment #3 from Leo Yang <leo.yang at torchmobile.com.cn>  2011-11-30 19:08:31 PST ---
(From update of attachment 116891)
View in context: https://bugs.webkit.org/attachment.cgi?id=116891&action=review

This is an informal review. LGTM, but some minor style issues.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:35
> +CredentialBackingStore* CredentialBackingStore::instance()
> +{
> +    static CredentialBackingStore *backingStore = 0;

The star in the above line should be near the type.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:47
> +CredentialBackingStore::CredentialBackingStore()
> +    : m_addStatement(0),
> +    m_updateStatement(0),
> +    m_hasStatement(0),
> +    m_getStatement(0),
> +    m_removeStatement(0)
> +{

comma should be at the beginning of each member variable.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:103
> +String CredentialBackingStore::encryptedString(const String& plainText) const
> +{
> +    // FIXME: need encrypt plain_text here

Nit: need --> Need

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:110
> +String CredentialBackingStore::decryptedString(const String& cipherText) const
> +{
> +    // FIXME: need decrypt cipher_text here

Ditto.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.h:36
> +    static CredentialBackingStore* instance();
> +    ~CredentialBackingStore();
> +

Blank line is not necessary.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.h:39
> +    bool open(const String& dbPath);
> +    void close();
> +

Ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.h:45
> +    Credential getLogin(const ProtectionSpace&);
> +    bool removeLogin(const ProtectionSpace&);
> +

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.