[Webkit-unassigned] [Bug 73430] [EFL] Add pre-rendering implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73430


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at samsung.com




--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-11-30 17:33:46 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 117177 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=117177&action=review
> > 
> > > Source/WebKit/efl/ewk/ewk_private.h:51
> > > +#define ARGB_BYTES_SIZE 4
> OK, I will fix it.
> > 
> > I think it is better to use EWK_ prefix to recognize that this macro is defined by ewebkit.
> > 
> > > Source/WebKit/efl/ewk/ewk_util.h:34
> > > +int ewk_util_rect_collision_check(int destinationX, int destinationY, int destinationWidth, int destinationHeight, int sourceX, int sourceY, int sourceWidth, int sourceHeight);
> > 
> > I'm not sure if we have to put this function on ewk_util.cpp. Will this function be able to be used by single backing store ?
> 
> the original intention was making a common basic API like eina_rectangle_interection. so I put them in ewk_util. I am also not sure it will be used in other function. So how do you think it should be moved?

If these functions will not be used by other functions, IMO, it is better to move them to ewk_tiled_xxx files. For example, ewk_tiled_private.h and so on. When other functions need to use them, I think we can move them to ewk_util.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.