[Webkit-unassigned] [Bug 73235] [Chromium] Support adding/removing page overlay to WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73235





--- Comment #17 from xiyuan <xiyuan at chromium.org>  2011-11-30 15:57:04 PST ---
(From update of attachment 117264)
View in context: https://bugs.webkit.org/attachment.cgi?id=117264&action=review

>> Source/WebKit/chromium/src/PageOverlay.cpp:181
>> +    // WebPageOverlayClient does the actual painting of the overlay.
> 
> I think getDirtyRect should be used here as well.
> Please move these FIXMEs to WebDevToolsAgentImpl::getDirtyRect() as well.

Done

>> Source/WebKit/chromium/src/WebViewImpl.cpp:2868
>> +                m_pageOverlays->update(true /*force*/);
> 
> I believe WebKit style is to use enums for that, not comments, e.g.:
>     enum PageOverlayUpdateOption {
>         ForceUpdate,
>         NotForceUpdate
>     };

Done.

>> Source/WebKit/chromium/src/WebViewImpl.h:576
>> +    // The DevTools agent.
> 
> This comment seems redundant.

Removed.

>> Source/WebKit/chromium/src/WebViewImpl.h:579
>> +    // PageOverlays for this WebView.
> 
> This comment seems redundant.

Removed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.