[Webkit-unassigned] [Bug 56466] Popup menu can get stuck in closed state when GtkMenu can't grab mouse.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56466


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116895|review?                     |review-
               Flag|                            |




--- Comment #16 from Martin Robinson <mrobinson at webkit.org>  2011-11-30 12:44:14 PST ---
(From update of attachment 116895)
View in context: https://bugs.webkit.org/attachment.cgi?id=116895&action=review

> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:114
>  
>      g_signal_handler_disconnect(m_popup->platformMenu(), unmapHandler);
>  
> -    if (!m_client)
> -        return;
> -
>      m_client->valueChangedForPopupMenu(this, m_activeItem);

This worries me. What if the client existed before you ran the main loop, but not after. If the client can be null before and after the main loop run you need to check in both places. I'm not convinced that it can be null before though...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.