[Webkit-unassigned] [Bug 73351] ASSERT fails in updateState ACTION_DRAW case

Wed Nov 30 11:42:24 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=73351

--- Comment #4 from Armand <armand.navabi at gmail.com>  2011-11-30 11:42:24 PST ---
Yes that is the failing ASSERT.  I'm sorry, my initial report had a typo.  

The state we get into is one in which m_needsCommit is *false* and m_visible is *false*.  In such a state, ACTION_COMMIT in updateState will set m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_TO_DRAW (since !m_visible is true).

Then, an ACTION_DRAW happens where m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_TO_DRAW and m_needsCommit is false (and m_visible is false).  Here the assertion fails.

Nat: I was not planning on putting up my patch because I am not confident it is the correct solution.  The patch I had was to change the assertion to ASSERT(m_needsCommit || !m_visible) in ACTION_DRAW.  While this would solve this particular failure, I am not familiar enough with this code to know if this is correct.

One question is, should ACTION_DRAW even be triggered when m_visible is false?  If not, then the assertion in question is not the problem, but the problem is that ACTION_DRAW is being called even though m_visible is false.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.