[Webkit-unassigned] [Bug 73306] [Chromium] [WebSocket] Add didUpdateBufferedAmount() callback to WebKit::WebSocketClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73306





--- Comment #4 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-11-30 10:37:29 PST ---
(From update of attachment 116959)
View in context: https://bugs.webkit.org/attachment.cgi?id=116959&action=review

> Source/WebKit/chromium/public/WebSocketClient.h:50
>      virtual void didReceiveMessage(const WebString& message) = 0;

By the way, we have the convention of providing default implementations for all
WebKit API methods that are intended to be implemented by the embedder.  We don't
use the OVERRIDE macro on the Chromium side.  This is all done to minimize the
pain of changing embedder implemented APIs.

However, it has the drawback that the compiler will not tell you if you forget to
implement a method.  I think we have been happier reducing the amount of back-n-forth
required to make WebKit API changes.  So, please feel free to provide default implementations
for these methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.