[Webkit-unassigned] [Bug 73421] Reuse cached style fully if the parent inherited styles are equal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 30 09:23:46 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73421





--- Comment #4 from Darin Adler <darin at apple.com>  2011-11-30 09:23:45 PST ---
(From update of attachment 117167)
View in context: https://bugs.webkit.org/attachment.cgi?id=117167&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:332
> +        && inherited.get() == other->inherited.get()
> +#if ENABLE(SVG)
> +        && m_svgStyle.get() == other->m_svgStyle.get()
> +#endif
> +        && rareInheritedData.get() == other->rareInheritedData.get();

I’m surprised these get() calls were needed. You typically can compare smart pointers without an explicit get() call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list