[Webkit-unassigned] [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70304





--- Comment #33 from Dongwoo Joshua Im <dw.im at samsung.com>  2011-11-30 02:34:28 PST ---
(In reply to comment #32)
> (In reply to comment #31)
> > When I've tried to give a negative number to setWidth() and get width by width(),
> > some big positive number comes out.
> 
> The behavior of setting a negative value to a "unsigned long" property is defined by Web IDL specification.  If our binding code doesn't follow it, we should fix out binding code generator.
> 
> http://www.w3.org/TR/WebIDL/#es-unsigned-long


Then, we need to make another bug to take care of this exceptional case.

I think that bug doesn't need to block this bug, because that is not only for this bug but for general cases.



IMHO, we need to fix toUInt32 function to handle this exceptional case.

In JSHTMLInputElement.cpp file, setWidth() function calls impl's setWidth() using toUInt32().

  imp->setWidth(value.toUInt32(exec));


And, in JSValueInlineMethods.h file, toUInt32() function is define like this.

  inline uint32_t JSValue::toUInt32(ExecState* exec) const
  {
      // See comment on JSC::toUInt32, above.                                                           
      return toInt32(exec);
  }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.