[Webkit-unassigned] [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70304





--- Comment #31 from Dongwoo Joshua Im <dw.im at samsung.com>  2011-11-30 01:07:33 PST ---
(In reply to comment #30)
> (From update of attachment 113447 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113447&action=review
> 
> "unsigned long" of WebIDL is 32-bit unsigned integer, and we have parseHTMLNonNegativeInteger() and String::toUInt().
> 
> Please change it to "unsigned" unless you have any technical difficulties.

I'm trying to use unsigned rather than int.

Then, prototypes are defined like below.

unsigned height(bool ignorePendingStylesheets = false) const;
unsigned width(bool ignorePendingStylesheets = false) const;
void setHeight(unsigned);
void setWidth(unsigned);

When I've tried to give a negative number to setWidth() and get width by width(),
some big positive number comes out.

So, which one is better choice?
 1. prototype : void setHeight(int);
    In the function, if the parameter is less than 0, just set 0 rather than the parameter.

 2.  prototype : void setHeight(unsigned);
    In the function, casting the parameter as int and check if it is less than 0 or not, and set 0 if it is less than 0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.