[Webkit-unassigned] [Bug 73381] New: base port needs to implement diff_image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73381

           Summary: base port needs to implement diff_image
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P1
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: eric at webkit.org, abarth at webkit.org,
                    hayato at chromium.org


Right now, only chromium port implements diff_image. This would mean that python throws an exception like the one below whenever ref-test fails:

Line:61 Path does not exist. platform/mac/fonts/color-bitmap.html
worker/0 raised TypeError('argument 1 must be string or buffer, not None'):
  layout_tests/controllers/worker.py:91 (in run)
    self._worker_connection.run_message_loop()
  layout_tests/controllers/message_broker.py:191 (in run_message_loop)
    self._broker.run_message_loop(self._run_topic, self._client, delay_secs)
  layout_tests/controllers/message_broker.py:127 (in run_message_loop)
    self._run_loop(topic_name, client, block=True, delay_secs=delay_secs)
  layout_tests/controllers/message_broker.py:141 (in _run_loop)
    self._dispatch_message(msg, client)
  layout_tests/controllers/message_broker.py:150 (in _dispatch_message)
    message_handler(message.src, *optargs)
  layout_tests/controllers/worker.py:111 (in handle_test_list)
    self._run_test(test_input)
  layout_tests/controllers/worker.py:126 (in _run_test)
    result = self.run_test_with_timeout(test_input, test_timeout_sec)
  layout_tests/controllers/worker.py:165 (in run_test_with_timeout)
    return self._run_test_in_this_thread(test_input)
  layout_tests/controllers/worker.py:250 (in _run_test_in_this_thread)
    return self.run_single_test(self._driver, test_input)
  layout_tests/controllers/worker.py:254 (in run_single_test)
    test_input, driver, self._name)
  layout_tests/controllers/single_test_runner.py:46 (in run_single_test)
    return runner.run()
  layout_tests/controllers/single_test_runner.py:124 (in run)
    return self._run_reftest()
  layout_tests/controllers/single_test_runner.py:292 (in _run_reftest)
    test_result_writer.write_test_result(self._port, self._test_name, driver_output1, driver_output2, test_result.failures)
  layout_tests/controllers/test_result_writer.py:74 (in write_test_result)
    writer.write_image_diff_files(image_diff)
  layout_tests/controllers/test_result_writer.py:207 (in write_image_diff_files)
    fs.write_binary_file(diff_filename, image_diff)
  common/system/filesystem.py:205 (in write_binary_file)
    f.write(contents)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.