[Webkit-unassigned] [Bug 73182] Need SSE optimization for functions vfmul and vadd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73182





--- Comment #11 from Wei James <james.wei at intel.com>  2011-11-29 17:12:53 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Created an attachment (id=116909)
 --> (https://bugs.webkit.org/attachment.cgi?id=116909&action=review) [details] [details] [details]
> > > Update the patch (Implement the SSE optimization for vsmul and vadd)
> > 
> > Hi Raymond,
> >     We tested again by moving the if statement out of the loop in vadd and vsmul then we got about 10%~20% improvement in vadd compared with no lifting it outside, but the vsmul`s performance increased less than 1%, so we leave the if inside in vsmul. 
> > 
> >     By the way could you point out the style issues in our code, that should be very helpful for us, thank you.
> 
> What exactly do you mean by 10-20% improvement?  Does that mean that if the original non-SSE code took 1 sec, the first SSE code now takes .7 sec (you said 30% improvement previously), and now the new SSE code takes .6 sec (10 percentage points more) or now takes .63 sec (.7 sec - 10%)?  Just want to know what it means.  I agree with you that vsmul should be left as is and vadd should lift the code out.
> 
> The style guide is here:  http://www.webkit.org/coding/coding-style.html, if you haven't seen it.  The easiest way to see the style issues is to run Tools/Scripts/check-webkit-style while in the third_party/WebKit directory.  If that doesn't work, I'll manually go and point out the issues in the review.
> 
> Note that I do not have commit privileges, so the code will need to be reviewed again by someone who does.
> 
> But thanks for doing the test and updating the code!  It's a nice improvement.

thanks for the information, we will run the script and update the patch again to fix the style issues. 

for the performance detail, for example, if the time for non-SSE code vadd and vsmul are both 100, then the time for first SSE version are 50 and 40. And the time for second version SSE are 44 and 39.8 or so.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.