[Webkit-unassigned] [Bug 36156] XHR 'progress' event code assumes wrongly that expectedLength >= 0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 17:09:51 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=36156





--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2011-11-29 17:09:51 PST ---
(From update of attachment 117071)
View in context: https://bugs.webkit.org/attachment.cgi?id=117071&action=review

Looks good. A few more trivial comments below.

> Source/WebCore/xml/XMLHttpRequest.cpp:1087
> -
> +        

Some of us prefer no trailing whitespace, and others don't care. Please don't just add it to lines that were not modified.

> LayoutTests/http/tests/xmlhttprequest/chunked-progress-event-expectedLength.html:33
> +	}
> +    }

There are tabs in this file. Please replace them with spaces.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list