[Webkit-unassigned] [Bug 72754] Send an AXCheckedStateChanged notification when the aria-checked attribute changes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72754


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117061|review?                     |review-
               Flag|                            |




--- Comment #7 from chris fleizach <cfleizach at apple.com>  2011-11-29 16:03:42 PST ---
(From update of attachment 117061)
View in context: https://bugs.webkit.org/attachment.cgi?id=117061&action=review

this test will likely fail on mac, windows and gtk so you should ask this test to those Skipped lists

> Source/WebCore/dom/Element.cpp:778
>      } else if (attrName == aria_selectedAttr)

no brackets for the else if since it's a one liner

> LayoutTests/accessibility/aria-checkbox-sends-notification.html:18
> +                return;

no need to special case out AXLayoutComplete.
Just check that CheckedStateChange has been seen two times.

> LayoutTests/accessibility/aria-checkbox-sends-notification.html:20
> +

notificationCount++ should suffice (instead of += 1)

> LayoutTests/accessibility/aria-checkbox-sends-notification.html:26
> +

no need to add a test complete yourself. the js-test-post should do that

> LayoutTests/accessibility/aria-checkbox-sends-notification.html:41
> +        }, 10);

i would remove this block. the test will timeout anyway if it doesn't finish, and this block may mask a true failure
if we're not receiving the notifications something is wrong

> LayoutTests/accessibility/aria-checkbox-sends-notification.html:47
> +        }, false);

there's no need to do this through an addEventListener. you can just call runTest() and it should work just fine

> LayoutTests/accessibility/aria-checkbox-sends-notification.html:57
> +

you're missing the js-test-post include here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.