[Webkit-unassigned] [Bug 73235] [Chromium] Support adding/removing page overlay to WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73235





--- Comment #9 from Vsevolod Vlasov <vsevik at chromium.org>  2011-11-29 14:46:49 PST ---
(In reply to comment #7)
> Change updated.
> 
> Acutally, I found that having multiple overlay layers seems unnecessary since we are always re-painting all the overlay clients. I am thinking maybe I should get rid of the PageOverlayList and changing PageOverlay to support multiple clients. What do you guys think?

Maybe PageOverlay::update() should have different behavior for dimming vs. inspector.
Why do you need to invalidate your dimming in each WebViewImpl::composite call?
Inspector needs invalidating on each composite because highlighted element might have moved, but I am not sure you ever need to invalidate dimming layer at all. 

Is that performance critical? James, what do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.