[Webkit-unassigned] [Bug 72048] --webkit-visual-word should be able to reach end of text, instead of end of line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72048


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117040|review?                     |review+
               Flag|                            |




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-11-29 13:58:59 PST ---
(From update of attachment 117040)
View in context: https://bugs.webkit.org/attachment.cgi?id=117040&action=review

> Source/WebCore/editing/visible_units.cpp:1615
> +    // FIXME: how to handle non-editable position?

"How should we handle a non-editable position"

> Source/WebCore/editing/visible_units.cpp:1616
> +    if (leftWordBreak.isNull() && isEditablePosition(visiblePosition.deepEquivalent())) {

Please use visiblePosition.rootEditableElement() instead.

> Source/WebCore/editing/visible_units.cpp:1631
> +    // FIXME: how to handle non-editable position?

Ditto.

> Source/WebCore/editing/visible_units.cpp:1632
> +    if (rightWordBreak.isNull() && isEditablePosition(visiblePosition.deepEquivalent())) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.