[Webkit-unassigned] [Bug 73336] New: Get rid of AllowCrossThreadAccess throughout ThreadableWebSocketChannelClientWrapper

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73336

           Summary: Get rid of AllowCrossThreadAccess throughout
                    ThreadableWebSocketChannelClientWrapper
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: toyoshim at chromium.org
        Depends on: 73290
            Blocks: 67942


We shouldn't use "AllowCrossThreadAccess" in ThreadableWebSocketChannelClientWrapper.

Here's why:
1. It was added to highlight the places where we were not doing anything to help with lifetime of the object being passed.
2. At the time it was added, ThreadSafeRefCounted* objects passed through createCallbackTask did not have the ref count increased, so AllowCrossThreadAccess needed to be added here.
3. ThreadableWebSocketChannelClientWrapper is designed to be ref counted across threads -- largely to make sure that its lifetime is preserved by this call.

This issue is derived from a review in https://bugs.webkit.org/show_bug.cgi?id=73290

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.