[Webkit-unassigned] [Bug 71968] Implement URL API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 05:02:48 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71968





--- Comment #31 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2011-11-29 05:02:47 PST ---
(In reply to comment #30)
> (In reply to comment #29)
> > > > Source/WebCore/html/DOMURL.cpp:239
> > > > +    m_href.setQuery(newSearch.replace('#', "%23"));
> > > 
> > > This looks suspicious.
> > 
> > This was to make sure that "#" in the search does not leak to hash. Do u think should be removed?
> 
> I thought that KURL would do the right thing but I see that it doesn't. I kind of wonder if it would not be cleaner to fix KURL here? (and remove this code from HTMLAnchorElement etc)

Yes, agree. We can mark it as FIXME as of now may be if you say.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list