[Webkit-unassigned] [Bug 73181] GetById should not always speculate cell

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 15:47:13 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73181





--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2011-11-28 15:47:13 PST ---
Did some more testing.  On three machines, two say it's a 1% speed-up on SunSpider.  All agree that it's never a suite-wide slow-down.


[pizlo at nitroflex bencher] ./bencher TipOfTree:/Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc PrimGetBase:/Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc --remote bigmac,oldmac --local
Packaging VM builds for remote hosts...
Sending VM builds to bigmac...
Running on bigmac...
376/376                                                          
Generating benchmark report at TipOfTree_PrimGetBase_SunSpiderV8Kraken_20111128_1539_benchReport.txt

Benchmark report for SunSpider, V8, and Kraken on bigmac.local (MacPro5,1).

VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r101284)
"PrimGetBase" at /Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc (r101284)

Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample
measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

                                            TipOfTree              PrimGetBase                                   
SunSpider:
   3d-cube                                7.4780+-0.0338    ?     7.5631+-0.0704       ? might be 1.0114x slower
   3d-morph                               8.3794+-0.0263    ?     8.3862+-0.0493       ?
   3d-raytrace                            7.6756+-0.0646          7.6697+-0.0663       
   access-binary-trees                    1.6025+-0.0061    ?     1.6184+-0.0187       ?
   access-fannkuch                        7.5638+-0.0144    ?     7.5961+-0.0677       ?
   access-nbody                           4.1779+-0.0059          4.1712+-0.0066       
   access-nsieve                          3.1806+-0.0610          3.1654+-0.0511       
   bitops-3bit-bits-in-byte               1.2576+-0.0146          1.2559+-0.0167       
   bitops-bits-in-byte                    4.9101+-0.0101    ?     4.9144+-0.0091       ?
   bitops-bitwise-and                     3.2889+-0.0062    ?     3.3027+-0.0281       ?
   bitops-nsieve-bits                     5.6385+-0.0340    ?     5.6838+-0.0307       ?
   controlflow-recursive                  2.2882+-0.0148    ?     2.3068+-0.0246       ?
   crypto-aes                             7.3165+-0.1264          7.1837+-0.0298         might be 1.0185x faster
   crypto-md5                             2.4968+-0.0163          2.4851+-0.0112       
   crypto-sha1                            2.1852+-0.0202          2.1704+-0.0242       
   date-format-tofte                     10.9162+-0.1806         10.7168+-0.0490         might be 1.0186x faster
   date-format-xparb                     10.2837+-0.0786    ?    10.3161+-0.0585       ?
   math-cordic                            7.1304+-0.0171          7.1299+-0.0141       
   math-partial-sums                     10.4567+-0.0166    ?    10.4760+-0.0163       ?
   math-spectral-norm                     2.6032+-0.0138    ?     2.6356+-0.0355       ? might be 1.0124x slower
   regexp-dna                            12.9907+-0.0619         12.9844+-0.0567       
   string-base64                          3.9341+-0.0113    ?     3.9393+-0.0328       ?
   string-fasta                           7.2805+-0.0250    ?     7.3061+-0.0279       ?
   string-tagcloud                       12.6944+-0.2381    ^    12.3246+-0.0397       ^ definitely 1.0300x faster
   string-unpack-code                    22.5829+-0.2149    ^    20.8383+-0.0729       ^ definitely 1.0837x faster
   string-validate-input                  5.6676+-0.0639          5.6334+-0.0458       

   <arithmetic> *                         6.7685+-0.0245    ^     6.6836+-0.0216       ^ definitely 1.0127x faster
   <geometric>                            5.3929+-0.0205          5.3716+-0.0208         might be 1.0040x faster
   <harmonic>                             4.2050+-0.0187    ?     4.2057+-0.0212       ? might be 1.0002x slower

                                            TipOfTree              PrimGetBase                                   
V8:
   crypto                                77.5226+-0.2322    ?    77.9864+-0.9023       ?
   deltablue                            169.7851+-1.7646        169.6010+-0.4459       
   earley-boyer                         105.1151+-0.6689        104.2461+-0.9092       
   raytrace                              63.5504+-0.5358         63.3546+-0.7003       
   regexp                               123.2564+-0.3934    ?   124.0168+-0.4199       ?
   richards                             139.0477+-0.8965    ?   139.6537+-0.9692       ?
   splay                                 91.6804+-1.2889         91.2435+-0.5677       

   <arithmetic>                         109.9939+-0.4302    ?   110.0146+-0.3116       ? might be 1.0002x slower
   <geometric> *                        104.7188+-0.3804        104.7077+-0.3762         might be 1.0001x faster
   <harmonic>                            99.6309+-0.3553         99.5902+-0.4561         might be 1.0004x faster

                                            TipOfTree              PrimGetBase                                   
Kraken:
   ai-astar                             810.4444+-13.1403       809.6979+-12.7046      
   audio-beat-detection                 205.1040+-0.8461    ?   205.4453+-1.0497       ?
   audio-dft                            263.3491+-2.0901        263.0357+-2.4775       
   audio-fft                            134.2887+-1.1583        134.0898+-1.0666       
   audio-oscillator                     280.5459+-5.7741        279.1194+-5.6857       
   imaging-darkroom                     336.7036+-6.4946        335.1863+-5.8131       
   imaging-desaturate                   239.1597+-0.4294    ?   239.4964+-0.8094       ?
   imaging-gaussian-blur                620.8288+-0.3080        620.7478+-0.2371       
   json-parse-financial                  72.8266+-0.3181    ?    73.2295+-0.2992       ?
   json-stringify-tinderbox              86.2131+-0.4738         86.0411+-0.1989       
   stanford-crypto-aes                  118.8909+-0.6087    ?   119.0576+-0.7136       ?
   stanford-crypto-ccm                  117.4354+-0.8587    ?   117.9361+-0.9807       ?
   stanford-crypto-pbkdf2               231.5623+-0.5704        231.2513+-1.7567       
   stanford-crypto-sha256-iterative      97.0698+-0.6541         96.9024+-0.1677       

   <arithmetic> *                       258.1730+-1.0446        257.9455+-1.0910         might be 1.0009x faster
   <geometric>                          199.8580+-0.4996        199.7999+-0.5660         might be 1.0003x faster
   <harmonic>                           161.7211+-0.3350    ?   161.8019+-0.3445       ? might be 1.0005x slower

                                            TipOfTree              PrimGetBase                                   
All benchmarks:
   <arithmetic>                          97.0289+-0.3198         96.9173+-0.3483         might be 1.0012x faster
   <geometric>                           24.6045+-0.0696         24.5480+-0.0758         might be 1.0023x faster
   <harmonic>                             7.4134+-0.0324    ?     7.4145+-0.0368       ? might be 1.0002x slower

                                            TipOfTree              PrimGetBase                                   
Geomean of preferred means:
   <scaled-result>                       56.7725+-0.1377         56.5157+-0.1617         might be 1.0045x faster

Sending VM builds to oldmac...
Running on oldmac...
376/376                                                          
Generating benchmark report at TipOfTree_PrimGetBase_SunSpiderV8Kraken_20111128_1543_benchReport.txt

Benchmark report for SunSpider, V8, and Kraken on oldmac.local (MacPro4,1).

VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r101284)
"PrimGetBase" at /Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc (r101284)

Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample
measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

                                            TipOfTree              PrimGetBase                                   
SunSpider:
   3d-cube                                9.0066+-0.0477    ?     9.0121+-0.0599       ?
   3d-morph                              10.2638+-0.1520         10.1205+-0.0431         might be 1.0142x faster
   3d-raytrace                            9.1961+-0.0779    ?     9.2441+-0.0808       ?
   access-binary-trees                    1.9105+-0.0048          1.9052+-0.0077       
   access-fannkuch                        9.1503+-0.0190    ?     9.2546+-0.1284       ? might be 1.0114x slower
   access-nbody                           5.0455+-0.0124    ?     5.0459+-0.0167       ?
   access-nsieve                          3.7153+-0.0082    ?     3.7156+-0.0059       ?
   bitops-3bit-bits-in-byte               1.4890+-0.0093          1.4869+-0.0051       
   bitops-bits-in-byte                    5.9610+-0.0352          5.9280+-0.0149       
   bitops-bitwise-and                     3.9673+-0.0049    ?     3.9674+-0.0049       ?
   bitops-nsieve-bits                     6.9107+-0.1347          6.8730+-0.0693       
   controlflow-recursive                  2.7627+-0.0211    ?     2.7736+-0.0343       ?
   crypto-aes                             8.7018+-0.0575          8.6662+-0.0710       
   crypto-md5                             2.9923+-0.0209          2.9710+-0.0133       
   crypto-sha1                            2.6121+-0.0267          2.5949+-0.0201       
   date-format-tofte                     13.1067+-0.0938    ?    13.1965+-0.1883       ?
   date-format-xparb                     12.7721+-0.1489    ?    12.7738+-0.1099       ?
   math-cordic                            8.6052+-0.0188    ?     8.6407+-0.0344       ?
   math-partial-sums                     12.6441+-0.0302         12.6343+-0.0174       
   math-spectral-norm                     3.1234+-0.0074    ?     3.1282+-0.0088       ?
   regexp-dna                            15.6127+-0.1023    ?    15.7199+-0.0777       ?
   string-base64                          4.7357+-0.0323    ?     4.7482+-0.0351       ?
   string-fasta                           8.8043+-0.0128    ?     8.8276+-0.0135       ?
   string-tagcloud                       15.0680+-0.1302    ^    14.8620+-0.0553       ^ definitely 1.0139x faster
   string-unpack-code                    27.7005+-0.1855    ^    25.7607+-0.0791       ^ definitely 1.0753x faster
   string-validate-input                  6.8233+-0.0647          6.7523+-0.0623         might be 1.0105x faster

   <arithmetic> *                         8.1800+-0.0240    ^     8.1001+-0.0306       ^ definitely 1.0099x faster
   <geometric>                            6.4953+-0.0198          6.4708+-0.0228         might be 1.0038x faster
   <harmonic>                             5.0431+-0.0169          5.0333+-0.0162         might be 1.0019x faster

                                            TipOfTree              PrimGetBase                                   
V8:
   crypto                                93.6356+-0.1878         93.5075+-0.3641       
   deltablue                            205.0982+-2.4375    ?   206.2358+-1.6268       ?
   earley-boyer                         125.9509+-0.8903    ?   126.0171+-0.8782       ?
   raytrace                              76.0511+-0.5249         75.8008+-0.6860       
   regexp                               147.8428+-0.3353    ?   148.2622+-0.4273       ?
   richards                             168.5417+-1.7057        167.7990+-0.8774       
   splay                                108.0922+-1.1576    ?   108.5410+-1.7636       ?

   <arithmetic>                         132.1732+-0.5308    ?   132.3091+-0.4720       ? might be 1.0010x slower
   <geometric> *                        125.6786+-0.4562    ?   125.7489+-0.4773       ? might be 1.0006x slower
   <harmonic>                           119.4567+-0.4400    ?   119.4615+-0.5149       ? might be 1.0000x slower

                                            TipOfTree              PrimGetBase                                   
Kraken:
   ai-astar                             897.5581+-0.4232    ?   897.7406+-0.4645       ?
   audio-beat-detection                 249.8704+-1.1648        249.5691+-0.9221       
   audio-dft                            315.1016+-2.9135    ?   316.5375+-5.3376       ?
   audio-fft                            162.8627+-1.1459        161.9474+-0.1085       
   audio-oscillator                     343.4602+-6.8557        340.6483+-7.0170       
   imaging-darkroom                     405.4188+-6.5577    ?   410.1651+-7.7088       ? might be 1.0117x slower
   imaging-desaturate                   288.1475+-0.0680    ?   288.1888+-0.0936       ?
   imaging-gaussian-blur                750.9272+-0.2813    ?   753.0340+-3.8911       ?
   json-parse-financial                  88.3435+-0.2050    ?    89.3216+-1.0965       ? might be 1.0111x slower
   json-stringify-tinderbox             103.3917+-0.2686    !   104.4470+-0.5087       ! definitely 1.0102x slower
   stanford-crypto-aes                  143.2825+-0.3786        143.0949+-0.5344       
   stanford-crypto-ccm                  140.4347+-0.9444    ?   140.8037+-1.1101       ?
   stanford-crypto-pbkdf2               280.6541+-2.3518    ?   282.4666+-2.4946       ?
   stanford-crypto-sha256-iterative     117.7556+-0.2287        117.2969+-0.2862       

   <arithmetic> *                       306.2292+-0.6652    ?   306.8044+-1.0606       ? might be 1.0019x slower
   <geometric>                          240.0051+-0.5082    ?   240.5002+-0.7923       ? might be 1.0021x slower
   <harmonic>                           195.0847+-0.3216    ?   195.6304+-0.6321       ? might be 1.0028x slower

                                            TipOfTree              PrimGetBase                                   
All benchmarks:
   <arithmetic>                         115.4277+-0.2161    ?   115.5751+-0.3661       ? might be 1.0013x slower
   <geometric>                           29.5924+-0.0666         29.5511+-0.0851         might be 1.0014x faster
   <harmonic>                             8.8915+-0.0293          8.8751+-0.0282         might be 1.0018x faster

                                            TipOfTree              PrimGetBase                                   
Geomean of preferred means:
   <scaled-result>                       68.0276+-0.1328         67.8604+-0.1874         might be 1.0025x faster

Running locally...
376/376                                                          
Generating benchmark report at TipOfTree_PrimGetBase_SunSpiderV8Kraken_20111128_1545_benchReport.txt

Benchmark report for SunSpider, V8, and Kraken on nitroflex.local (MacBookPro8,2).

VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r101284)
"PrimGetBase" at /Volumes/Data/pizlo/secondary/OpenSource/WebKitBuild/Release/jsc (r101284)

Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample
measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

                                            TipOfTree              PrimGetBase                                   
SunSpider:
   3d-cube                                7.1575+-0.2354          7.0259+-0.1505         might be 1.0187x faster
   3d-morph                               7.7520+-0.1157          7.6741+-0.1134         might be 1.0102x faster
   3d-raytrace                            7.2676+-0.1825          7.2460+-0.1797       
   access-binary-trees                    1.4984+-0.0355    ?     1.5297+-0.0242       ? might be 1.0209x slower
   access-fannkuch                        6.4619+-0.0754          6.3424+-0.0660         might be 1.0188x faster
   access-nbody                           3.5086+-0.1024    ?     3.5466+-0.0891       ? might be 1.0108x slower
   access-nsieve                          2.5459+-0.0602    ?     2.6406+-0.1078       ? might be 1.0372x slower
   bitops-3bit-bits-in-byte               1.2702+-0.0136          1.2641+-0.0285       
   bitops-bits-in-byte                    2.4118+-0.0716          2.3517+-0.0529         might be 1.0256x faster
   bitops-bitwise-and                     3.3894+-0.0471    ?     3.4552+-0.0794       ? might be 1.0194x slower
   bitops-nsieve-bits                     5.4325+-0.0844          5.3813+-0.0660       
   controlflow-recursive                  2.0755+-0.0348    ?     2.1106+-0.0465       ? might be 1.0169x slower
   crypto-aes                             7.0370+-0.1188    ?     7.1524+-0.1332       ? might be 1.0164x slower
   crypto-md5                             2.4499+-0.1045          2.3751+-0.0625         might be 1.0315x faster
   crypto-sha1                            2.1846+-0.0960          2.0737+-0.0642         might be 1.0534x faster
   date-format-tofte                     10.4930+-0.2104         10.3721+-0.2436         might be 1.0117x faster
   date-format-xparb                      9.9807+-0.1289          9.9722+-0.1931       
   math-cordic                            6.4187+-0.1320    ?     6.6768+-0.1320       ? might be 1.0402x slower
   math-partial-sums                      7.7358+-0.2155          7.5927+-0.1210         might be 1.0189x faster
   math-spectral-norm                     2.3983+-0.0515          2.3510+-0.0458         might be 1.0201x faster
   regexp-dna                            11.0343+-0.1563    ?    11.3721+-0.2315       ? might be 1.0306x slower
   string-base64                          3.9461+-0.0869          3.8731+-0.1100         might be 1.0188x faster
   string-fasta                           6.8034+-0.1689          6.7259+-0.1369         might be 1.0115x faster
   string-tagcloud                       11.2997+-0.1995    ?    11.3845+-0.3282       ?
   string-unpack-code                    20.3005+-0.1728    ^    19.2393+-0.3765       ^ definitely 1.0552x faster
   string-validate-input                  5.5259+-0.1239    ?     5.5339+-0.2025       ?

   <arithmetic> *                         6.0915+-0.0278          6.0486+-0.0246         might be 1.0071x faster
   <geometric>                            4.8592+-0.0148          4.8389+-0.0195         might be 1.0042x faster
   <harmonic>                             3.8274+-0.0250          3.8133+-0.0219         might be 1.0037x faster

                                            TipOfTree              PrimGetBase                                   
V8:
   crypto                                71.8634+-0.6151    ?    71.9204+-0.4422       ?
   deltablue                            152.7037+-1.6896        150.7131+-1.2730         might be 1.0132x faster
   earley-boyer                          86.2757+-1.0717         85.8455+-1.0990       
   raytrace                              58.1938+-0.8018         58.1324+-0.7145       
   regexp                               105.8389+-1.5551        105.7282+-0.5079       
   richards                             118.7512+-0.4150        118.6073+-0.3495       
   splay                                 74.8425+-0.9998         74.6712+-0.7341       

   <arithmetic>                          95.4956+-0.3730         95.0883+-0.2553         might be 1.0043x faster
   <geometric> *                         91.0251+-0.2901         90.7330+-0.2765         might be 1.0032x faster
   <harmonic>                            86.9640+-0.2730         86.7571+-0.3269         might be 1.0024x faster

                                            TipOfTree              PrimGetBase                                   
Kraken:
   ai-astar                             499.1011+-3.2941    ?   507.9335+-6.0009       ? might be 1.0177x slower
   audio-beat-detection                 194.4367+-1.8181        192.0391+-0.6806         might be 1.0125x faster
   audio-dft                            274.8032+-2.4003        274.7899+-2.5654       
   audio-fft                            127.4657+-1.2184        126.9612+-0.8764       
   audio-oscillator                     253.4097+-3.7310        253.1290+-3.5523       
   imaging-darkroom                     308.0198+-4.0310        307.1233+-4.2552       
   imaging-desaturate                   220.3319+-1.4803        219.7745+-1.8169       
   imaging-gaussian-blur                562.6962+-2.3110    ?   564.9762+-5.5238       ?
   json-parse-financial                  58.7835+-0.1501    !    59.9569+-0.5711       ! definitely 1.0200x slower
   json-stringify-tinderbox              74.6116+-0.2465    ?    74.7934+-0.3159       ?
   stanford-crypto-aes                  100.2818+-0.9061    ?   100.2845+-0.3721       ?
   stanford-crypto-ccm                  103.2332+-0.7825        102.9859+-0.7070       
   stanford-crypto-pbkdf2               193.2819+-2.3420        192.4260+-0.5078       
   stanford-crypto-sha256-iterative      84.7929+-0.2269    ?    85.2704+-0.3352       ?

   <arithmetic> *                       218.2321+-0.5294    ?   218.7460+-0.6582       ? might be 1.0024x slower
   <geometric>                          174.5910+-0.4056    ?   174.8366+-0.4773       ? might be 1.0014x slower
   <harmonic>                           141.1413+-0.2883    ?   141.5817+-0.4700       ? might be 1.0031x slower

                                            TipOfTree              PrimGetBase                                   
All benchmarks:
   <arithmetic>                          82.5978+-0.1791    ?    82.6665+-0.2077       ? might be 1.0008x slower
   <geometric>                           21.8487+-0.0447         21.7968+-0.0589         might be 1.0024x faster
   <harmonic>                             6.7404+-0.0431          6.7164+-0.0379         might be 1.0036x faster

                                            TipOfTree              PrimGetBase                                   
Geomean of preferred means:
   <scaled-result>                       49.4611+-0.0927         49.3305+-0.0818         might be 1.0026x faster

[pizlo at nitroflex bencher]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list