[Webkit-unassigned] [Bug 70484] [WK2] add flag to only check pixel results if png files exist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70484





--- Comment #21 from Dirk Pranke <dpranke at chromium.org>  2011-11-28 15:26:10 PST ---
(In reply to comment #20)
> (In reply to comment #19)
> > (In reply to comment #16)
> > > Created an attachment (id=116019)
 --> (https://bugs.webkit.org/attachment.cgi?id=116019&action=review) [details] [details] [details]
> > > Patch
> > > 
> > > The unittest, don't work for me, i think it is, becasue of a bug in nrwt.
> > > Any idea why don't work?
> > 
> > Can you provide more information on why it isn't working? What is happening?
> 
> I think one of the method, which call this function work wrong. The unittest system throw this message:
> 
> FAIL: test_skip_pixel_test_if_no_baseline_option (webkitpy.layout_tests.port.webkit_unittest.WebKitPortTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/feherzsolt/webkit/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py", line 162, in test_skip_pixel_test_if_no_baseline_option
>     self.assertTrue(test_name in self.png_list)
> AssertionError: False is not true
> 

This is telling you that skip_pixel_test returned False, i.e., that one of the test files did have an expected image, but that that test wasn't in  your png_list. You'll have to add some debug statements to figure out which test it is, and what port.expected_image() is returning (and why).

Also, we try not to hard-code in real test names, and the TestWebKitPort is probably using a MockHost, which hopefully means a mock filesystem with a fake list of tests (set in webkitpy/layout_tests/port/test.py). If that is true, you should use some of the fake test names instead of the real test names you're using.


> ----------------------------------------------------------------------
> Ran 1237 tests in 22.667s
> 
> FAILED (failures=1)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.