[Webkit-unassigned] [Bug 70634] Mark GraphicsLayers as opaque when possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70634





--- Comment #79 from Dana Jansens <danakj at chromium.org>  2011-11-28 13:50:19 PST ---
(In reply to comment #77)
> Why can't you just assume that all canvases are not opaque?

What I'm not seeing is a way to tell that a RenderImage is a canvas at all. Am I just missing it somewhere?

What I've seen is that the StyleImage class has an isGeneratedImage() which is true for a canvas. I was thinking to have

RenderImageResource::isGeneratedImage() { return false; }

and then RenderImageResourceStyleImage could override it and give something useful. And the opaque-check could just ignore generated images.

Side-note: it would be easier and cleaner to simply remove any changes to RenderImage.cpp from this bug and stick that in another one, would that be good for you Simon?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.