[Webkit-unassigned] [Bug 73143] Upstream BlackBerry porting of page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73143





--- Comment #9 from Daniel Bates <dbates at webkit.org>  2011-11-28 11:39:51 PST ---
(In reply to comment #8)
> (From update of attachment 116640 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116640&action=review
> 
> >> Source/WebCore/page/blackberry/DragControllerBlackBerry.cpp:21
> >> +#include "DragController.h"
> > 
> > Swap these lines.
> 
> Thanks for your review Dan, I will follow your advices. But I don't get why do we need to swap these lines? Seems we don't need to include "DragController.h" if we don't define DRAG_SUPPORT.

I spoke with Jacky on IRC today about this. I suggest swapping these lines so as to be consistent with both the WebKit Code Style Guidelines (*) and the form used in DragControllerMac.mm. That being said, is this guard even needed in this file? Is it necessary to even compile this file without drag support? I assume that the callers of these functions are guarded with ENABLE(DRAG_SUPPORT) and hence we don't need to even compile is file when building without drag support. Notice that the DragController implementation file for all non-Mac ports omit such a DRAG_SUPPORT guard.

(*) See (2) of section "#include Statements" of <http://www.webkit.org/coding/coding-style.html>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.