[Webkit-unassigned] [Bug 71385] Threaded compositor should delegate overflow div/iframe scroll events to WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 11:33:49 PST 2011


--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-11-28 11:33:49 PST ---
(From update of attachment 116256)
View in context: https://bugs.webkit.org/attachment.cgi?id=116256&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:307
> +    // Set coordinates of scrollable elements inside the layer. These are given
> +    // in scaled document coordinates.
> +    const Vector<IntRect>& scrollableRects() const { return m_scrollableRects; }
> +    virtual void setScrollableRects(const Vector<IntRect>& r) { m_scrollableRects = r; }

It's not clear what "scrollable rects" are for. Why aren't the child scrollable things in their own GraphicsLayers?

> Source/WebCore/rendering/RenderLayer.cpp:3884
> +Vector<IntRect> RenderLayer::scrollableChildren() const

This isn't returning a list of children, it's returning a list of rects, so the name is wrong.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list