[Webkit-unassigned] [Bug 73040] FloatQuad::isRectilinear() returns false for 180degree rotations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 10:54:39 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73040


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116761|review?                     |review+
               Flag|                            |




--- Comment #10 from James Robinson <jamesr at chromium.org>  2011-11-28 10:54:39 PST ---
(From update of attachment 116761)
View in context: https://bugs.webkit.org/attachment.cgi?id=116761&action=review

Thanks for the test. R=me

> Source/WebKit/chromium/tests/FloatQuadTest.cpp:26
> +// FIXME: If we get the TestWebKitAPI framework to bring a full Frame + DOM stack
> +// in a portable way, this test should be shared with all ports!

this FIXME doesn't really belong in this test - it's not something to do with this file

> Source/WebKit/chromium/tests/FloatQuadTest.cpp:52
> +    TransformationMatrix nonRectilinearTrans[8];

are there any transformations other than rotations that are interesting for this logic?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list