[Webkit-unassigned] [Bug 73156] [Microdata] Implement HTMLProprtiesCollection collection.namedItem().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73156


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116721|review?                     |review-
               Flag|                            |




--- Comment #8 from Adam Barth <abarth at webkit.org>  2011-11-28 10:05:36 PST ---
(From update of attachment 116721)
View in context: https://bugs.webkit.org/attachment.cgi?id=116721&action=review

We should be able to do this without custom bindings code.

> Source/WebCore/bindings/v8/custom/V8HTMLPropertiesCollectionCustom.cpp:64
> +    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
> +        return notHandledByInterceptor();
> +    if (info.Holder()->HasRealNamedCallbackProperty(name))
> +        return notHandledByInterceptor();

This pattern is very subtle.  Are you sure you've got it right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.