[Webkit-unassigned] [Bug 73206] WebKitGTK+-1.7.2 build error due to a reference to gdk_disable_multidevice()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73206





--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2011-11-28 09:26:32 PST ---
(In reply to comment #3)
> Looks like testatk needs some GTK 2.x love or we should finally decide to drop GTK+ 2.x.

I think this problem could be easily solved by just replacing that initializeTestingFramework() function with a regular call to gtk_test_init() + g_setenv("GTK_MODULES", "gail", TRUE), since what that weird function is trying to do is just to ensure the "gail" module is loaded for the unit tests.

Guess now it's when you ask me why in hell I haven't done this first, instead of adding that initializeTestingFramework() function, and the truth is that I just realized about this being a better solution two days ago, while talking to Carlos García Campos... so sorry about that, it was my fault in the beginning.

I will make a patch then and will attach it as soon as I make sure it works fine in the bots. Sorry in advance Stefan for causing you trouble with this and for probably deprecating your patch with the new one I'd be attaching, but if my suggestion works I think it would be a better solution, since it does not rely on copy&paste from GTK, but in a simple call to gtk_test_init()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.