[Webkit-unassigned] [Bug 73040] FloatQuad::isRectilinear() returns false for 180degree rotations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73040





--- Comment #7 from Dana Jansens <danakj at chromium.org>  2011-11-28 07:10:20 PST ---
(In reply to comment #6)
> (From update of attachment 116411 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116411&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (will be covered in layout tests for opaque flag: https://bugs.webkit.org/show_bug.cgi?id=70634)
> 
> really? you can't even right a unit test for this?

I can make a chromium unit test sure. Just not looking to be redirected to fixing the general unit test framework to work with WebCore again.

> > Source/WebCore/platform/graphics/FloatQuad.cpp:89
> > +static inline bool equal(float a, float b)
> 
> do we actually need this? are there actual cases where exact comparisons fail but this succeeds?

Rotate a rect by 180 degrees and an == test will fail in the 12th decimal place or so. Thus is no longer considered opaque and won't use AA etc.

> this function name isn't very good since it isn't actually testing for equality

ok will change.

> > Source/WebCore/platform/graphics/FloatQuad.cpp:91
> > +    return fabs(a - b) < std::numeric_limits<float>::epsilon();
> 
> WebKit style is to not use the 'std::' qualifier here, add an appropriate using definition at the top of the .cpp and use numeric_limits<> unqualified.

ok! thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.