[Webkit-unassigned] [Bug 72484] [v8] Exception thrown in npObjectInvokeImpl may overwrite the exception message thrown by NPN_SetException

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72484





--- Comment #6 from Steve Block <steveblock at google.com>  2011-11-28 03:33:53 PST ---
(From update of attachment 116645)
View in context: https://bugs.webkit.org/attachment.cgi?id=116645&action=review

> Source/WebCore/bindings/v8/V8NPObject.cpp:135
> +        // If an exception is already thrown by invoke/invokeDefault/construct,

I think this could be worded more clearly - 'A return value of true is used to indicate that an exception has been thrown.'

> Source/WebCore/bindings/v8/V8NPObject.cpp:139
> +        if (NPVARIANT_IS_BOOLEAN(result) && NPVARIANT_TO_BOOLEAN(result))

Presumably we can't test directly for an exception having been thrown? If not, this approach seems reasonable to me, but you should get a formal review from whoever owns this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.