[Webkit-unassigned] [Bug 71968] Implement URL API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71968





--- Comment #29 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2011-11-28 03:26:01 PST ---
(In reply to comment #28)
> (From update of attachment 116565 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116565&action=review
> 
> > Source/WebCore/html/DOMURL.cpp:154
> > +    if (value.isEmpty() || value == "null")
> 
> Remove"null" case
> 

Fixed that.

> > Source/WebCore/html/DOMURL.cpp:239
> > +    m_href.setQuery(newSearch.replace('#', "%23"));
> 
> This looks suspicious.

This was to make sure that "#" in the search does not leak to hash. Do u think should be removed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.