[Webkit-unassigned] [Bug 73185] [blackberry] Upstream BlackBerry porting of plugin framework

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73185





--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-11-27 23:24:30 PST ---
(From update of attachment 116702)
View in context: https://bugs.webkit.org/attachment.cgi?id=116702&action=review

Random drive by nit:

> Source/WebCore/plugins/blackberry/PluginPackageBlackBerry.cpp:84
> +    NPP_GetMIMEDescriptionProcPtr gm = (NPP_GetMIMEDescriptionProcPtr) dlsym(m_module, "NP_GetMIMEDescription");
> +    NPP_GetValueProcPtr gv = (NPP_GetValueProcPtr) dlsym(m_module, "NP_GetValue");

This variable names are pretty short.  Usually we like complete words in variable names.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.