[Webkit-unassigned] [Bug 72584] Support Image Level 3's image() notation; it offers automated image flipping for RTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72584





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-11-27 13:17:19 PST ---
(From update of attachment 116678)
View in context: https://bugs.webkit.org/attachment.cgi?id=116678&action=review

> Source/WebCore/ChangeLog:8
> +        Parse CSS3's image() notation.

Please explain what kind of changes you're making and also add a url to the spec where the notation is specified.

> Source/WebCore/ChangeLog:706
> -        
> +

Please revert these changes to old changelog entries.

> Source/WebCore/css/CSSImageFallbackValue.cpp:25
> +

No blank line here.

> Source/WebCore/css/CSSImageFallbackValue.cpp:33
> +    size_t n = this->m_images.size();

Please don't use one-letter variable line n.

> Source/WebCore/css/CSSParser.cpp:6289
> +    const CSSParserString& fname = val->function->name;

Please don't use abbreviations like "f".

> Source/WebCore/css/CSSParser.cpp:6378
> +    CSSParserValue* a = args->current();

Ditto about one-letter variable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.