[Webkit-unassigned] [Bug 73074] StyleGeneratedImage should ref CSSImageGeneratorValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73074


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116631|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Andreas Kling <kling at webkit.org>  2011-11-25 09:57:19 PST ---
(From update of attachment 116631)
View in context: https://bugs.webkit.org/attachment.cgi?id=116631&action=review

r=me. Patch looks great, and I believe you've addressed the issues Nikolas brought up.

> Source/WebCore/css/CSSImageGeneratorValue.cpp:40
>  CSSImageGeneratorValue::CSSImageGeneratorValue(ClassType classType)

Unrelated to this patch: CSSImageGeneratorValue's ctor and dtor could be inlined.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:394
> +    typedef T Setter;
> +    typedef T Getter;

I think Setter/Getter are poor names here. SetterType/GetterType perhaps?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.