[Webkit-unassigned] [Bug 72835] Web Inspector: [protocol] generate C++ classes for protocol JSON named types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72835





--- Comment #17 from Peter Rybin <peter.rybin at gmail.com>  2011-11-25 08:22:24 PST ---
> I generally like the result, but still got a few notes:
> - reinterpret_cast from InspectorObject to a specific object type looks quite unfortunate. Why not use a concrete type for m_result?
done

> - why do we need explicit inlines on every method?
done

> - let's pass string parameters by a const reference;
done

> - Builder constructor should by private, with outer class a friend;
done

> - it's probably worth implementing cast operator for PassRefPtr via cast operator for RefPtr;
done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.