[Webkit-unassigned] [Bug 69835] [GStreamer] WebAudio AudioDestination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69835


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116355|review?                     |review+
               Flag|                            |




--- Comment #33 from Martin Robinson <mrobinson at webkit.org>  2011-11-24 05:21:45 PST ---
(From update of attachment 116355)
View in context: https://bugs.webkit.org/attachment.cgi?id=116355&action=review

> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:106
> +    // Autoaudiosink does the real sink detection in the
> +    // GST_STATE_NULL->READY transition so it's best to roll it to READY as
> +    // soon as possible to ensure the underlying platform
> +    // audiosink was loaded correctly.

Super nit: Do you mind evening out these lines?

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:324
> +    if (!priv->provider || !priv->bus)
> +        return;

You can probably remove this since you assert above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.