[Webkit-unassigned] [Bug 73005] http-cache can break app-cache's functionality

Wed Nov 23 21:16:42 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=73005

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116329|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2011-11-23 21:16:42 PST ---
(From update of attachment 116329)
Safari does not have this issue.

> But this time it will get the body from http-cache, and the status-code is 304.

This is where the bug is. HTTP cache should not send a 304 over when first loading an appcache. It would be useless, as it has no data, it has different headers etc. This is something you need to fix in your network back-end for it to be usable with WebKit. I guess that you might be adding response body after 304, which made regular browsing work, but that's not how it's supposed to be implemented.

Note that 304 can be returned when updating appcache (if HTTP cache doesn't have the response cached). That case is handled right above the line you modified in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.