[Webkit-unassigned] [Bug 73039] [Web Intents] Flagged-off implementation of an intent tag for registration.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73039





--- Comment #7 from Greg Billock <gbillock at google.com>  2011-11-23 17:18:54 PST ---
(From update of attachment 116390)
View in context: https://bugs.webkit.org/attachment.cgi?id=116390&action=review

>> Source/WebCore/html/HTMLIntentElement.cpp:51
>> +    document()->frame()->loader()->client()->registerIntentService(
> 
> given a Document, the frame() method can return null.  however, i'm not sure if it can really be null in this case.  i see other insertedIntoDocument() implementations checking frame() though.

Added checks here. It looks like Frame always has a FrameLoader. I'm not sure about the others, though...

>> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1630
>> +    WebCore::KURL serviceURL(baseURL, href); // need TextEncoding?
> 
> I think you should be using {Web}Document::completeURL() for this instead.

Done. Thanks.

>> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1634
>> +        m_webFrame->client()->registerIntentService(webFrame(), service);
> 
> nit: use m_webFrame instead of webFrame()

Done.

>> Source/WebKit/chromium/src/FrameLoaderClientImpl.h:211
>> +    virtual void registerIntentService(
> 
> when you are inside the implementation of WebKit, you don't need the WTF:: prefix on WTF types.

Done. (Usage in this file predominates to WTF::String though.)

>> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36
>> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action,
> 
> This class is also defined in the patch from https://bugs.webkit.org/show_bug.cgi?id=73036.

Yes. I plan on checking in that one first and merging here. I included it here for completeness (so the patch builds).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.