[Webkit-unassigned] [Bug 73036] Add simple implementation for web intents chromium API data classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73036





--- Comment #6 from Greg Billock <gbillock at google.com>  2011-11-23 16:48:50 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Right. I didn't export the constructor for that reason. Will this break the shared lib?
> 
> Ah, OK... since the class is only ever created by WebKit, then you should hide this constructor behind #if WEBKIT_IMPLEMENTATION.  That way we can avoid the possibility of someone trying to construct it outside of WebKit.

Done.

> 
> 
> > There will be a WebCore::Intent class; I have that constructor in a separate CL which I'm going to send along soon. For now I just wanted some simple method implementations so I can check in the adjustments to our Chromium code that will use these accessors. I could take the constructors out completely. Shall I just do that?
> 
> I guess you can initialize these classes by just calling the setFoo methods, right?

Sounds good. I just replaced them with empty constructors; I'll adapt to that in the other CLs when I merge.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.